Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Border Title API #97
base: master
Are you sure you want to change the base?
feat: New Border Title API #97
Changes from 6 commits
b1cac8a
f3ebe5c
2b9468b
2795dbc
346a978
80468e0
32c0787
3e6dff3
fec27d1
cd06217
9b317d1
80169c0
27c2a27
314a2e2
78fea2f
0c829e8
4cf8c19
9e516bc
d59ed63
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably use
Padding(0, 1)
instead of manually adding spaces to demonstrate theBorderTitleStyle
best practices.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this does not work as I use actual text to calculate the required text width.
@maaslalani Do you know of any API to calculate the screen width of styled text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it might be
GetHorizontalFrame
to calculate all the padding and margin horizontally and then add the width of the text.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd additionally add logic where, if horizontal padding is unset on the style it defaults to
Padding(0, 1)
:However if horizontal padding is set, accept it at face value. For example,
PaddingLeft(0).PaddingRight(3)
would render as: