Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Override onInview function (fixes #76) #77

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix: Override onInview function (fixes #76) #77

merged 1 commit into from
Jan 14, 2025

Conversation

guywillis
Copy link
Contributor

Fixes: #76

Fix

  • Override onInview function within pageNav to set completion only to top

@guywillis guywillis self-assigned this Jan 14, 2025
@guywillis guywillis requested a review from swashbuck January 14, 2025 17:25
@oliverfoster oliverfoster merged commit e9729c7 into master Jan 14, 2025
1 check passed
@oliverfoster oliverfoster deleted the issue/76 branch January 14, 2025 17:44
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.1.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@swashbuck swashbuck Awaiting requested review from swashbuck

Assignees

@guywillis guywillis

Labels
bug enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change inview completion to top
2 participants
@guywillis @oliverfoster