Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change inview completion to top #76

Closed
swashbuck opened this issue Nov 19, 2024 · 1 comment · Fixed by #77
Closed

Change inview completion to top #76

swashbuck opened this issue Nov 19, 2024 · 1 comment · Fixed by #77

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Nov 19, 2024

Subject of the issue

This component is almost always used as a bookend to a page. In certain cases when the plugin is not set to optional, the component is not fully scrolled into view. A use case that we found involved a screen reader user using keyboard navigation on a laptop viewed at 150% zoom level. The Trickle would autoscroll to the Page Nav block. However, because the entire Page Nav was not scrolled into view, the "next" button remained disabled. The user needed to disable the virtual cursor and manually scroll down to enable register inview completion which then enabled "next" button.

Suggest changing inview completion to require that only the top of the Page Nav comes into view.

It would also be helpful to include the default _isOptional value in the example.json as a reminder to developers that it needs to be reviewed. We typically will set this to 'false' but it defaults to 'true' like other presentation components.

Screenshots

Here, the Page Nav has not come fully into view. So, the "next" button is not enabled. This can cause issues with keyboard navigation.
pagenav

@swashbuck swashbuck self-assigned this Dec 3, 2024
github-actions bot pushed a commit that referenced this issue Jan 14, 2025
## [3.1.7](v3.1.6...v3.1.7) (2025-01-14)

### Fix

* Override onInview function (fixes #76) ([e9729c7](e9729c7)), closes [#76](#76)
Copy link

🎉 This issue has been resolved in version 3.1.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant