Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sharing dialog to hub #2987

Merged
merged 7 commits into from
Feb 27, 2025
Merged

add sharing dialog to hub #2987

merged 7 commits into from
Feb 27, 2025

Conversation

emmachughes
Copy link
Member

@emmachughes emmachughes commented Feb 18, 2025

Brings up a dialog when hitting the 'share' button. If copying doesn't work (e.g. due to iframe sandbox reasons), the user can still copy the URL for sharing manually.

image

@github-actions github-actions bot added the Component: Hub The core of Edlib - handling search, filtering, my content and shared content label Feb 18, 2025
@emmachughes emmachughes linked an issue Feb 18, 2025 that may be closed by this pull request
@emmachughes emmachughes requested a review from chrieinv February 20, 2025 14:01
@emmachughes emmachughes merged commit b3e16ea into master Feb 27, 2025
6 checks passed
@emmachughes emmachughes deleted the hub-sharing-dialog branch February 27, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Hub The core of Edlib - handling search, filtering, my content and shared content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to copy URL to clipboard
2 participants