GH #2939: Remove small screen design for card and list-item #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrieinv
commented
Feb 5, 2025
•
chrieinv
commented
- Remove separate design of card and list-item for small screens
- Set min-width on content container to prevent layout issues on very narrow screens. For Grid layout min width is 290px and on List it's 460px.
- Improve display of paginator on small screens and for many pages
…guage name, other minor design adjustments
github-actions
bot
added
the
Component: Hub
…ode, and fixed number of cards for different widths
github-actions
bot
added
the
language
chrieinv
requested review from
emmachughes
and removed request for
emmachughes
emmachughes
requested changes
Feb 11, 2025
emmachughes
requested changes
Feb 24, 2025
| } | ||
|
|
||
| min-width: 250px; | ||
| min-width: 290px; // Same as min-with of main-container |
There was a problem hiding this comment.
This could be a varible instead of copy/pasting it everywhere. Also the comment contains a typo.
| @@ -1,3 +1,8 @@ | |||
| .content-list-item { | |||
| min-width: 450px; | |||
| min-width: 460px; // Same as min-with of main-container | |||
There was a problem hiding this comment.
Could also be a variable, and also contains a typo.
| @@ -57,7 +58,7 @@ class="btn-close m-2 align-self-start" | |||
| @endif | |||
|
|
|||
| <div @class(['container-md' => !$expand, 'flex-grow-1'])> | |||
| <main class="h-100 d-flex flex-column"> | |||
| <main @class(['h-100', 'd-flex', 'flex-column', 'main-container-grid' => $layout === 'grid', 'main-container-list' => $layout === 'list'])> | |||
There was a problem hiding this comment.
It would be better if the layout component took a generic main_classes property, rather than letting details specific to sublayouts leak into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.