improves handling off odd situation states for governance proposals. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I guess it makes sense, bit complex but it is what it is |
nicolasbrugneaux
previously approved these changes
Feb 26, 2025
|
i compared the 2 versions in browser side by side and nothing changed that should not. eye ball test |
nicolasbrugneaux
approved these changes
Feb 26, 2025
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initiated by situation when a proposal failed, its replacement suceeded, but we never ran the scripts while it was active on chain. now the github metadata points to the correct proposals and the on chain proposal id is expired.
note the most crucial fix is that even though we were correctly using executed-ids to determine that we were passing in the wrong old votes.
moving around to and new tests are mostly about making this easier to fix if there is an issue in future with an active on-chain replacement proposal.