Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support for Qiskit 1.0 #364

Merged
merged 1 commit into from
Feb 21, 2024
Merged

✨ Support for Qiskit 1.0 #364

merged 1 commit into from
Feb 21, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR marks the official support of Qiskit 1.0 in QCEC.

In order to avoid all kinds of ugly compatibility hacks, this PR also changes the minimum required Qiskit version to 1.0.
Since Qiskit has devoted themselves to following semantic versioning from now on out, this hopefully means fewer compatibility changes in the future.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added feature New feature or request dependencies Pull requests that update a dependency file python Anything related to Python code minor Part of a minor release labels Feb 21, 2024
@burgholzer burgholzer self-assigned this Feb 21, 2024
@burgholzer burgholzer enabled auto-merge (squash) February 21, 2024 06:55
@burgholzer burgholzer disabled auto-merge February 21, 2024 07:09
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de87600) 96.3% compared to head (5e5d1ea) 90.8%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #364     +/-   ##
=======================================
- Coverage   96.3%   90.8%   -5.6%     
=======================================
  Files         34      34             
  Lines       1753    1753             
  Branches     215     215             
=======================================
- Hits        1689    1592     -97     
- Misses        64     161     +97     
Flag Coverage Δ *Carryforward flag
cpp 96.1% <ø> (ø) Carriedforward from de87600
python 72.5% <ø> (-24.7%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@burgholzer burgholzer enabled auto-merge (squash) February 21, 2024 08:00
@burgholzer burgholzer merged commit 6349fc5 into main Feb 21, 2024
27 checks passed
@burgholzer burgholzer deleted the qiskit-1.0 branch February 21, 2024 08:23
@lucasberent lucasberent mentioned this pull request Apr 17, 2024
4 tasks
lucasberent added a commit to cda-tum/mqt-qecc that referenced this pull request Apr 19, 2024
## Description
This PR adds Qiskit 1.0 support, see
cda-tum/mqt-qcec#364. Qiskit terra is removed,
the qiskit_aer dependency updated, and deprecated function calls
replaced in accordance with the code change rules summarized in
https://docs.quantum.ibm.com/api/migration-guides/qiskit-1.0-features
(this mainly affects .qasm calls in this PR).

Thereby Fixes #210.
## Checklist:
- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [x] I have made sure that all CI jobs on GitHub pass.
- [x] The pull request introduces no new warnings and follows the
project's style guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature New feature or request minor Part of a minor release python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant