Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Only enable IPO per default for Release builds outside of deployment #841

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

burgholzer
Copy link
Member

Description

Basically the PR title. From past experience, IPO can make debugging quite hard.
This PR ensures that, at least in non-release builds, IPO is not enabled by default.
As such, no manual workarounds should be necessary anymore for debugging.

This change transitively propagates to all dependants of MQT Core once they update to the latest version.

@ystade tagging for awareness

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines

…uilds outside of deployment

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Feb 26, 2025
@burgholzer burgholzer added usability Anything related to usability c++ Anything related to C++ code labels Feb 26, 2025
@burgholzer burgholzer added this to the MQT Core milestone Feb 26, 2025
@burgholzer burgholzer enabled auto-merge (squash) February 26, 2025 00:10
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.3%. Comparing base (fc6bb4b) to head (e47e6d1).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #841   +/-   ##
=====================================
  Coverage   92.3%   92.3%           
=====================================
  Files        127     127           
  Lines      13556   13555    -1     
  Branches    2086    2086           
=====================================
+ Hits       12520   12521    +1     
+ Misses      1036    1034    -2     
Flag Coverage Δ
cpp 92.1% <ø> (+<0.1%) ⬆️
python 99.7% <ø> (ø)

see 1 file with indirect coverage changes

@burgholzer burgholzer merged commit 7ed6a74 into main Feb 26, 2025
31 checks passed
@burgholzer burgholzer deleted the only-ipo-in-release-mode branch February 26, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant