-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Installation Improvements #539
Conversation
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
…s` targets Note that this will require upstream projects to explicitly link against these targets. This makes sure that no options are forced on targets that incorporate mqt-core Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
=======================================
- Coverage 91.2% 91.2% -0.1%
=======================================
Files 130 130
Lines 13709 13709
Branches 2155 2155
=======================================
- Hits 12510 12509 -1
- Misses 1199 1200 +1
|
That one cpp-linter failure cannot be fixed here since |
Signed-off-by: burgholzer <burgholzer@me.com>
11428c9
to
c597e64
Compare
…ort` extra Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Cpp-Linter Report
|
Description
This PR improves a couple of bits and pieces throughout the library and should increase the overall usability and DX.
Most notable breaking changes:
MQT::CorePython
target is removed. After this PR is merged, top-level packages are expected to use themqt.core
Python package for translating from Qiskit to MQT. Furthermore, the top-level packages are responsible for bringing in thepybind11_json
dependency if they require it, as it is no longer shipped withmqt-core
.MQT::ProjectOptions
andMQT::ProjectWarnings
targets are now linked privately into the libraries in order to not pollute other CMake targets. This means that top-level projects now also need to explicitly link against these targets if they want to benefit from the common settings.include/mqt-core
subdirectory to create a cleaner installation structure.Checklist: