🚨🏁 address compiler warnings on windows

Signed-off-by: Lukas Burgholzer <burgholzer@me.com>
cda-tum · Feb 4, 2025 · e7a8e15 · e7a8e15
1 parent 01c6a80
commit e7a8e15
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/include/mqt-core/qasm3/passes/TypeCheckPass.hpp b/include/mqt-core/qasm3/passes/TypeCheckPass.hpp
@@ -110,7 +110,7 @@ class TypeCheckPass final : public CompilerPass,
   visitConstantExpression(std::shared_ptr<Constant> constantInt) override;
   InferredType visitIdentifierExpression(
       std::shared_ptr<IdentifierExpression> identifierExpression) override;
-  [[noreturn]] InferredType
+  InferredType
   visitIdentifierList(std::shared_ptr<IdentifierList> identifierList) override;
   InferredType visitMeasureExpression(
       std::shared_ptr<MeasureExpression> measureExpression) override;

diff --git a/src/algorithms/Grover.cpp b/src/algorithms/Grover.cpp
@@ -33,7 +33,7 @@ auto appendGroverOracle(QuantumComputation& qc,
                         const GroverBitString& targetValue) -> void {
   const auto nDataQubits = static_cast<Qubit>(qc.getNqubits() - 1);
   Controls controls{};
-  for (std::size_t i = 0; i < nDataQubits; ++i) {
+  for (Qubit i = 0; i < nDataQubits; ++i) {
     controls.emplace(i, targetValue.test(i) ? Control::Type::Pos
                                             : Control::Type::Neg);
   }

diff --git a/src/ir/QuantumComputation.cpp b/src/ir/QuantumComputation.cpp
@@ -362,7 +362,8 @@ void QuantumComputation::addQubitRegister(std::size_t nq,
         "qubits have been added");
   }
 
-  quantumRegisters.try_emplace(regName, nqubits, nq, regName);
+  quantumRegisters.try_emplace(regName, static_cast<Qubit>(nqubits), nq,
+                               regName);
   for (std::size_t i = 0; i < nq; ++i) {
     auto j = static_cast<Qubit>(nqubits + i);
     initialLayout.insert({j, j});
@@ -404,7 +405,7 @@ void QuantumComputation::addAncillaryRegister(std::size_t nq,
         "[addAncillaryRegister] New register size must be larger than 0");
   }
 
-  const auto totalqubits = nqubits + nancillae;
+  const auto totalqubits = static_cast<Qubit>(nqubits + nancillae);
   ancillaRegisters.try_emplace(regName, totalqubits, nq, regName);
   ancillary.resize(totalqubits + nq);
   garbage.resize(totalqubits + nq);

diff --git a/src/qasm3/passes/TypeCheckPass.cpp b/src/qasm3/passes/TypeCheckPass.cpp
@@ -324,7 +324,7 @@ InferredType TypeCheckPass::visitIdentifierExpression(
   return type->second;
 }
 
-[[noreturn]] InferredType TypeCheckPass::visitIdentifierList(
+InferredType TypeCheckPass::visitIdentifierList(
     std::shared_ptr<IdentifierList> /*identifierList*/) {
   throw TypeCheckError("TypeCheckPass::visitIdentifierList not implemented");
 }

diff --git a/test/zx/test_expression.cpp b/test/zx/test_expression.cpp
@@ -211,7 +211,6 @@ TEST_F(ExpressionTest, Arithmetic) {
   const auto beta = zx::PiRational(1, 2);
 
   EXPECT_EQ(beta * 2, zx::PiRational(1, 1));
-  EXPECT_EQ(beta * 2., zx::PiRational(1, 1));
 
   const auto betaExpr = zx::PiExpression{beta};
   EXPECT_EQ(betaExpr * 2., zx::PiExpression{zx::PiRational(1, 1)});