Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ci_* prefix to z_ci_* in Terraform resources #109

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

jeancochrane
Copy link
Collaborator

@jeancochrane jeancochrane commented Mar 14, 2024

This PR updates the prefixes used by the resources defined in the Terraform config to match the convention we use in https://github.com/ccao-data/data-architecture, namely that staging resources get prefixed with z_ci_* instead of ci_* for better sorting in the AWS UI.

See here for an example of a deploy-terraform workflow run that successfully sets up resources with the new prefix, and here for an example of an equivalent cleanup-terraform run.

Closes #80.

@jeancochrane jeancochrane linked an issue Mar 14, 2024 that may be closed by this pull request
@jeancochrane
Copy link
Collaborator Author

Closing to test the cleanup step.

@jeancochrane jeancochrane reopened this Mar 14, 2024
@jeancochrane jeancochrane marked this pull request as ready for review March 14, 2024 19:25
@jeancochrane jeancochrane requested a review from dfsnow March 14, 2024 19:25
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The perfectionist in me has been waiting for this one.

@jeancochrane jeancochrane merged commit aa2fd56 into main Mar 14, 2024
5 checks passed
@jeancochrane jeancochrane deleted the jeancochrane/80-update-ci-prefix-to-match-dbt branch March 14, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI prefix to match dbt
2 participants