Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condo characteristics to vars_dict #24

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

wrridgeway
Copy link
Member

@wrridgeway wrridgeway commented Mar 11, 2024

Condo chars were never added to the ccao package.

@wrridgeway wrridgeway self-assigned this Mar 11, 2024
@wrridgeway wrridgeway linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fe992f9) to head (ecbbcac).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          382       382           
=========================================
  Hits           382       382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrridgeway wrridgeway marked this pull request as ready for review March 11, 2024 16:37
@wrridgeway wrridgeway requested a review from a team as a code owner March 11, 2024 16:37
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update

ccao/R/data.R

Line 184 in fe992f9

#' @format A data frame with 488 rows and 11 variables:
with a new row count, then run devtools::document() to update the man pages.

@wrridgeway
Copy link
Member Author

wrridgeway commented Mar 18, 2024

Will update data.R once we've decided on whether not to add strata vars back to vars_dict.csv.

@wrridgeway wrridgeway requested a review from dfsnow March 19, 2024 16:08
@wrridgeway wrridgeway marked this pull request as ready for review March 19, 2024 16:24
@dfsnow dfsnow changed the title Add condo characteristics to vars dict Add condo characteristics to vars_dict Mar 19, 2024
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. As long as this is the minimal update needed for renaming and we're not re-adding column descriptions here, then this is good to go.

@wrridgeway wrridgeway merged commit 969dae7 into master Mar 19, 2024
12 checks passed
@wrridgeway wrridgeway deleted the 23-add-condo-characteristics-new-vars-dict branch March 19, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add condo characteristics to vars dict
2 participants