feat: add option to style hyperref #19
Conversation
catppuccinpalette.dtx
Outdated
| % Style hyerref according to the styleguide\footnote{\url{https://github.com/catppuccin/catppuccin/blob/main/docs/style-guide.md\#typography}} if the user wants it | ||
| % \begin{macrocode} | ||
| \ifcatppuccinpalette@hyperref% | ||
| \PassOptionsToPackage{linkcolor=CtpBlue,citecolor=CtpGreen,filecolor=CtpSky,menucolor=CtpBlue,runcolor=CtpSky,urlcolor=CtpBlue}{hyperref}% |
There was a problem hiding this comment.
Not sure about all the colors here.
As far as I can see, https://github.com/catppuccin/catppuccin/blob/main/docs/style-guide.md#typography only defines Links and Urls. What about Cite, Run, Menu (not sure what this even is) and File?
As far as I remember I tried to choose colors similar than in default hyperref (thus Green for cites).
Any opinions?
There was a problem hiding this comment.
Apparently the option description for Menu is "Color for Acrobat menu items." Had to search a little far and wide for this, but apparently it opens an Acrobat menu item? Usage appears to be \href{menu:GoTo}{Go to a menu item}. 😆
I think since the style guide does not have specific rules for these cases, I think choosing similar colors to the hyperref defaults works, as long as they're still legible.
There was a problem hiding this comment.
I ran though the changes locally and all the colors look good / legible to me!
There was a problem hiding this comment.
Looks like there is also anchorcolor but probably this is not too relevant if it's ignored by most drivers.
For reference (with catppuccin):
For reference (default colors):
Not sure if url and link should get different colors. And if the citation color should be more highlighting. But then I don't want to violate the style-guide by making manual adjustments here (Cite is not defined, but I think there is no real (green) highlighting color in catppuccin and url/link is the same thing in the style-guide)
There was a problem hiding this comment.
I think the green here works! And I also think it's fine that URL and link colors are the same; if anything, I think the uniformity makes it more clear that they're links haha.
There was a problem hiding this comment.
True, I'm just thinking links refering to the web (opening a browser) should probably be somhow be visible as such. So I'm thinking of using another blue tone (probably Lavender or maybe Sapphire, also they are not allocated in the typography section of the style guide until now). What do you think?
There was a problem hiding this comment.
I think that sounds good! I'm leaning more towards the Lavendar since it has a connection to links, used for followed links, in the style guide. (and because I like it more 🤭)
but honestly either can work
There was a problem hiding this comment.
Ah I see, but fair point the color(-scheme)'s purpose is that you like it 😄
Hm for me either would be fine. I'm just a bit unsure if the difference between Blue and Lavender is big enough (especially when zooming out) 🤔 So I'm leaning a bit towards Sapphire. Though you have a point with the Style guide regarding followed links
With Sapphire:
With Lavender:
Anyhow I'd keep this PR open just for another few days in order to give people on discord a chance to respond regarding following the style guide.
atticus-sullivan
added
enhancement
catppuccinpalette.dtx
Outdated
| % Style hyerref according to the styleguide\footnote{\url{https://github.com/catppuccin/catppuccin/blob/main/docs/style-guide.md\#typography}} if the user wants it | ||
| % \begin{macrocode} | ||
| \ifcatppuccinpalette@hyperref% | ||
| \PassOptionsToPackage{linkcolor=CtpBlue,citecolor=CtpGreen,filecolor=CtpSky,menucolor=CtpBlue,runcolor=CtpSky,urlcolor=CtpBlue}{hyperref}% |
There was a problem hiding this comment.
Apparently the option description for Menu is "Color for Acrobat menu items." Had to search a little far and wide for this, but apparently it opens an Acrobat menu item? Usage appears to be \href{menu:GoTo}{Go to a menu item}. 😆
I think since the style guide does not have specific rules for these cases, I think choosing similar colors to the hyperref defaults works, as long as they're still legible.
catppuccinpalette.dtx
Outdated
| % Style hyerref according to the styleguide\footnote{\url{https://github.com/catppuccin/catppuccin/blob/main/docs/style-guide.md\#typography}} if the user wants it | ||
| % \begin{macrocode} | ||
| \ifcatppuccinpalette@hyperref% | ||
| \PassOptionsToPackage{linkcolor=CtpBlue,citecolor=CtpGreen,filecolor=CtpSky,menucolor=CtpBlue,runcolor=CtpSky,urlcolor=CtpBlue}{hyperref}% |
There was a problem hiding this comment.
I ran though the changes locally and all the colors look good / legible to me!
|
Merging in 24 h (with sapphire as url color) if no objections are raised. |
Refer to #18