Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read catppuccin-definitions.el in temp buffer instead of visiting #181

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ktbjob
Copy link
Contributor

@ktbjob ktbjob commented Aug 13, 2024

The catppuccin-definitions.el file is currently loaded using the find-file-noselect function, which is inappropriate for the following reasons:

  • It creates a file-visiting buffer that distracts the user and clutters their post-init Emacs state.
  • It runs additional code to initialize buffer major mode and so on, which are unnecessary.

This PR fixes the code to use a temporary buffer to read the contents of catppuccin-definitions.el and pass the contents to the lisp reader, avoiding the aforementioned issues.

@jtbx jtbx force-pushed the load-definitions-fix branch from 02d69de to 08d6009 Compare August 13, 2024 08:27
Copy link
Member

@jtbx jtbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for taking the time to contribute! I fixed the indentation errors on your branch which caused the CI to fail.

Other than that everything looks good <3

@jtbx jtbx merged commit 177ecee into catppuccin:main Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants