-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create codeql.yml #6
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new CodeQL workflow file that enables static analysis for Javascript and Typescript. The workflow is triggered on push and pull requests to the main branch, as well as on a weekly schedule. It sets up the necessary environment, including Python and dependencies, and then runs the CodeQL analysis. Flow diagram of the CodeQL workflowflowchart TD
Start[Trigger] --> Conditions{Trigger Type}
Conditions -->|Push| Main[Push to main]
Conditions -->|PR| PR[Pull Request to main]
Conditions -->|Schedule| Schedule[Weekly Schedule]
Main --> Checkout[Checkout Repository]
PR --> Checkout
Schedule --> Checkout
Checkout --> SetupPython[Setup Python 3.8]
SetupPython --> Cache[Cache pip dependencies]
Cache --> InstallDeps[Install Dependencies]
InstallDeps --> InitCodeQL[Initialize CodeQL]
InitCodeQL --> Analysis[Perform CodeQL Analysis]
Analysis --> End[End]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @canstralian - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the Python setup and pip installation steps since they're not being used for JavaScript/TypeScript analysis
- Update actions/setup-python and actions/cache to v3 to stay current with latest versions
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
uses: actions/setup-python@v2 | ||
with: | ||
python-version: '3.8' | ||
|
||
- name: Cache pip | ||
uses: actions/cache@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Consider updating the action versions and Python version to more recent releases
setup-python@v4, cache@v3, and a more recent Python version (e.g., 3.11) are available and would provide better security and performance benefits.
uses: actions/setup-python@v2 | |
with: | |
python-version: '3.8' | |
- name: Cache pip | |
uses: actions/cache@v2 | |
uses: actions/setup-python@v4 | |
with: | |
python-version: '3.11' | |
- name: Cache pip | |
uses: actions/cache@v3 |
'your code, for example:' | ||
echo ' make bootstrap' | ||
echo ' make release' | ||
exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The exit 1 command in the manual build section could cause unexpected failures if manual build mode is enabled
Consider removing the exit 1 and leaving just the echo commands as placeholders, or adding a clear comment that this section needs to be replaced before enabling manual build mode.
Summary by Sourcery
CI: