Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI badge for publishing snap #55

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Add CI badge for publishing snap #55

merged 2 commits into from
Jul 20, 2023
+4 −1

Conversation

dashmage
Copy link
Contributor

No description provided.

@dashmage dashmage requested review from a team, Pjack, aieri, esunar, agileshaw, jneo8 and rgildein July 13, 2023 10:55
rgildein
rgildein approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agileshaw
agileshaw suggested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed elsewhere, we want to explore the possibility of generating badges for non-default tracks. I'm setting my review status to "Request changes" to block this PR from being merged.

agileshaw
agileshaw approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After @dashmage 's investigation, it is currently not possible to generate badges for non-default tracks. So I'm approving this PR and creating a separate issue (#56) for future follow-up.

@dashmage dashmage merged commit ffcbef7 into canonical:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agileshaw agileshaw agileshaw approved these changes

@rgildein rgildein rgildein approved these changes

@Pjack Pjack Awaiting requested review from Pjack

@aieri aieri Awaiting requested review from aieri

@esunar esunar Awaiting requested review from esunar

@jneo8 jneo8 Awaiting requested review from jneo8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dashmage @agileshaw @rgildein