feat(charmcraft): get cos-tool directly #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This grabs the `cos-tool` release directly into the dump plugin rather than installing curl and using that. The net effect should be the same.
lengau
commented
Mar 5, 2025
| @@ -29,7 +29,7 @@ parts: | |||
| # Install PyYAML from binary and avoid building it from sources. This way, we can use PyYAML with C-optimized lib. | |||
| # With the C-optimized lib, serialization in ops is 20x faster. | |||
| - PyYAML | |||
| - cryptography | |||
| - cryptography==44.0.1 | |||
There was a problem hiding this comment.
This is a workaround to make the build work without re-syncing uv. It is obviated by #265 or can be separately fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
charmcraft.yamlfile unnecessarily installs and usescurlrather than using thedumpplugin directlySolution
This grabs the
cos-toolrelease directly into the dump plugin rather than installing curl and using that. The net effect should be the same.Context
I guess my specialised knowledge is the details about how parts work.
Testing Instructions
Ensure that
cos-tool-*in the charm still has the same permissions (looks like it to me):Upgrade Notes
n/a