Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix DataSourceAliYun exception_cb signature #6068

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix: Fix DataSourceAliYun exception_cb signature #6068

merged 1 commit into from
Mar 3, 2025
+2 −1

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

fix: Fix DataSourceAliYun exception_cb signature

Fixes GH-6066

Additional Context

Curious why mypy didn't catch this one. Pylance does.

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

holmanb
holmanb approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheRealFalcon!

@TheRealFalcon TheRealFalcon added this to the cloud-init-25.1 milestone Mar 3, 2025
@TheRealFalcon TheRealFalcon merged commit aba3791 into canonical:main Mar 3, 2025
22 checks passed
@TheRealFalcon TheRealFalcon deleted the fix-aliyun branch March 3, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmanb holmanb holmanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
cloud-init-25.1
Development

Successfully merging this pull request may close these issues.
2 participants
@TheRealFalcon @holmanb