Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analyze_boot): wrong return code analyze boot #6031

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AliyevH
Copy link
Contributor

@AliyevH AliyevH commented Feb 18, 2025

Returning string at the end causes sys.exit to exit with non zero code. Just removing return statement.

fixes: gh-4245

Proposed Commit Message

<type>(optional scope): <summary>  # no more than 72 characters

A description of what the change being made is and why it is being
made if the summary line is insufficient.  This should be wrapped at
72 characters.

If you need to write multiple paragraphs, feel free.

Fixes GH-NNNNN (GitHub Issue number. Remove line if irrelevant)
LP: #NNNNNN (Launchpad bug number. Remove line if irrelevant)

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Returning string at the end causes sys.exit to exit with non zero code.
Just removing return statement.

fixes: canonicalgh-4245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong return_code in analyze boot
1 participant