Oracle netplan v2 migration

[a-dubs]

Proposed Commit Message

feat(oracle): update Oracle Datasource to use netplan v2

Additional Context

Test Steps

Ran the full integration test suite against Noble using a custom deb created from this feature branch.

Merge type

• Squash merge using "Proposed Commit Message"

[TheRealFalcon]

See my inline comments. I think you added some good code, but much of it can move into tests.

Additionally, I forget, why are we moving to support both v1 and v2 now? Once we move to v2, is there any reason we would need to keep the v1 support around?

[a-dubs]

@TheRealFalcon thanks for the feedback! I guess the idea here was that by keeping the old v1 code around, we could do the comparisons on live systems that way if anyone ever finds a weird edge case then it will log a warning and they could file a bug. But honestly, now that you mention it, I do kinda prefer the idea of just having a super comprehensive unit test suite to verify it once and be done and then move on with our lives.

@holmanb thoughts? since this was your idea originally?

[holmanb]

@TheRealFalcon thanks for the feedback! I guess the idea here was that by keeping the old v1 code around, we could do the comparisons on live systems that way if anyone ever finds a weird edge case then it will log a warning and they could file a bug. But honestly, now that you mention it, I do kinda prefer the idea of just having a super comprehensive unit test suite to verify it once and be done and then move on with our lives.

@holmanb thoughts? since this was your idea originally?

The only benefit that I see of a runtime check is that it might catch edge cases that couldn't be predicted with a battery of unit tests. I'm fine with just getting some good test coverage instead if that's preferred.

[holmanb]

@a-dubs I left some comments below.

[Copilot]

PR Overview

This PR migrates the Oracle datasource configuration from netplan v1 to netplan v2 and improves test coverage for helper functions.

• Updates the Oracle datasource to use the new netplan v2 configuration schema.
• Adds a set of comprehensive unit tests for the dict comparison helper function.
• Introduces YAML import and logger initialization in the test helpers to support improved debugging.

Reviewed Changes

File	Description
tests/unittests/helpers.py	Adds YAML import, logger initialization, and the dicts_are_equal helper function.
tests/unittests/test_helpers.py	Introduces unit tests for the dicts_are_equal function.
cloudinit/sources/DataSourceOracle.py	Migrates Oracle datasource configuration from netplan v1 to v2 and refactors related methods.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

[Copilot]

The function convert_v1_netplan_to_v2 uses the protected method _render_content from netplan.Renderer, which may break if the internal API changes. Consider using a public API for rendering if available.