Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(azure): Fix imds-based ssh_pwauth #6002

Merged
merged 4 commits into from
Feb 20, 2025
Merged

feat(azure): Fix imds-based ssh_pwauth #6002

merged 4 commits into from
Feb 20, 2025

Conversation

KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented Feb 4, 2025

Proposed Commit Message

feat(azure): Fix imds-based ssh_pwauth

To enable/disable password authentication is only possible in the OVF code path.
If OVF is unavailable, we fall back to IMDS and we want to have the same logic.

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb self-assigned this Feb 7, 2025
TheRealFalcon
TheRealFalcon approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit 39937db into canonical:main Feb 20, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjp256 cjp256 cjp256 left review comments

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees

@holmanb holmanb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KsenijaS @TheRealFalcon @cjp256 @holmanb