-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aliyun datasource support crawl metadata at once #5942
Conversation
cloudinit log in alibaba cloud instance: cloudinit log in aws cloud instance, aws ec2 data source has removed content related to Aliyun, which has no impact on EC2 |
2ec5ea7
to
0a731d9
Compare
@holmanb @TheRealFalcon this update is a follow-up to the previous PR discussion. Please help review it |
@holmanb hello, could you please take a look. |
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
@holmanb @TheRealFalcon There are quite a few modifications. If there are any parts that need to be updated, please provide suggestions. We would be grateful and look forward to your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @jinkkkang! The general approach looks good. I've added some requests to the PR below.
Using the meta-data/all
endpoint should certainly help with performance. The logs appear to be using this endpoint. Is this endpoint currently available on Alibaba cloud?
Thank you for your reply, We have provided support for |
d40765a
to
aa1da70
Compare
@holmanb Thank you for your reply and fix mypy error code. all seems to be okay now |
Commenting in order to get notified when this merges. |
aa1da70
to
e2b0700
Compare
e2b0700
to
d0eeea8
Compare
@holmanb Sorry, I missed some mypy errors earlier and have fixed them all. Please help confirm again that there are no issues and assist with merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks for working on this @jinkkkang!
|
||
@return: The API token or None if unavailable. | ||
""" | ||
# if self.cloud_name not in IDMSV2_SUPPORTED_CLOUD_PLATFORMS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason to keep this commented code.
If _api_token is unset on AWS, attempt to refresh the token via a PUT | ||
and then return the updated token header. | ||
""" | ||
# if self.cloud_name not in IDMSV2_SUPPORTED_CLOUD_PLATFORMS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason to keep this commented code.
feat: aliyun datasource support crawl metadata at once
Additional Context
Test Steps
Merge type