-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vmware): Convert imc network config to Networking config Version 2 #5937
feat(vmware): Convert imc network config to Networking config Version 2 #5937
Conversation
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
tag @TheRealFalcon to reopen it, thanks~ |
@sshedi , is this something you could review too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes look good. I left a few inline comments.
Thanks @TheRealFalcon for the review, I'm traveling during spring festival here, probably won't be able to address any comments until Feb.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PengpengSun I believe this change is opaque to user, right?
Need some changes, PTAL.
Right, it converts customization config to network v2 config supported by cloud-init, not written network configuration to Guest OS directly.
Thanks @sshedi for the review, I will address the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @PengpengSun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
feat(vmware): Convert imc network config to v2 To support dhcp4-overrides and dhcp6-overrides, we need to convert network configuration read from imc configuration file to v2 instead of v1. This PR also adds ipv6 routes support. Fixes LP: #1776452
feat(vmware): Convert imc network config to v2 To support dhcp4-overrides and dhcp6-overrides, we need to convert network configuration read from imc configuration file to v2 instead of v1. This PR also adds ipv6 routes support. Fixes LP: #1776452
Proposed Commit Message
Additional Context
Test Steps
Merge type