Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vmware): Convert imc network config to Networking config Version 2 #5937

Conversation

PengpengSun
Copy link
Contributor

Proposed Commit Message

feat(vmware): Convert imc network config to Networking config Version 2

To support dhcp4-overrides and dhcp6-overrides, we need to convert network configuration read from imc configuration file to v2 instead of v1.
This PR also adds ipv6 routes support.

If you need to write multiple paragraphs, feel free.

Fixes LP: #1776452

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link

github-actions bot commented Jan 7, 2025

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Jan 7, 2025
@PengpengSun
Copy link
Contributor Author

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

tag @TheRealFalcon to reopen it, thanks~

@TheRealFalcon TheRealFalcon removed the stale-pr Pull request is stale; will be auto-closed soon label Jan 7, 2025
@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Jan 22, 2025
@TheRealFalcon TheRealFalcon removed the stale-pr Pull request is stale; will be auto-closed soon label Jan 22, 2025
@canonical canonical deleted a comment from github-actions bot Jan 22, 2025
@TheRealFalcon TheRealFalcon self-assigned this Jan 23, 2025
@TheRealFalcon
Copy link
Member

@sshedi , is this something you could review too?

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good. I left a few inline comments.

@PengpengSun
Copy link
Contributor Author

Overall the changes look good. I left a few inline comments.

Thanks @TheRealFalcon for the review, I'm traveling during spring festival here, probably won't be able to address any comments until Feb.5.

Copy link
Contributor

@sshedi sshedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PengpengSun I believe this change is opaque to user, right?

Need some changes, PTAL.

@PengpengSun
Copy link
Contributor Author

@PengpengSun I believe this change is opaque to user, right?

Right, it converts customization config to network v2 config supported by cloud-init, not written network configuration to Guest OS directly.

Need some changes, PTAL.

Thanks @sshedi for the review, I will address the comments.

Copy link
Contributor

@sshedi sshedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @PengpengSun

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit b38ab5f into canonical:main Feb 7, 2025
22 checks passed
@PengpengSun PengpengSun deleted the ds-vmware-imc-support-network-config-v2 branch February 8, 2025 04:46
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Feb 11, 2025
feat(vmware): Convert imc network config to v2

To support dhcp4-overrides and dhcp6-overrides, we need to convert
network configuration read from imc configuration file to v2 instead
of v1.

This PR also adds ipv6 routes support.

Fixes LP: #1776452
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Feb 11, 2025
feat(vmware): Convert imc network config to v2

To support dhcp4-overrides and dhcp6-overrides, we need to convert
network configuration read from imc configuration file to v2 instead
of v1.

This PR also adds ipv6 routes support.

Fixes LP: #1776452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants