Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paride to CLA signers #5590

Closed
wants to merge 1 commit into from

Conversation

paride
Copy link
Contributor

@paride paride commented Aug 7, 2024

Proposed Commit Message

chore: add myself (paride) to the CLA signers list

I was already present in tools/.lp-to-git-user, but with my old Launchpad
username. Instead of updating that, I'm just dropping the LP -> GitHub
mapping and adding myself directly to tools/.github-cla-signers.

Additional Context

This is a "bare" change, with no real changes to cloud-init code. The reason for this is that I plan to open a PR against the packaging branch (ubuntu/devel), but it doesn't feel right to update the CLA information there.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@blackboxsw
Copy link
Collaborator

Thanks @paride, but there is no real need to shift to .github-cla-signers as our workflow checks both files so you won't be prompted. I think at this point it may make sense for us to just retire the .lp-to-git-user file and pull github usernames into .github-cla-signers. We'll still have this historic commit referencing former LP users that transitioned their CLA signing to github. But I don't expect we will need to use that nowadays. Let's close this PR and we can discuss dropping this .lp-to-git-user file, workflow related functionality and the tools/migrate-lp-user-to-github as a separate pr.

@blackboxsw blackboxsw closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants