Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Integration tests #5576

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Aug 1, 2024

String output changed in 7703634.
Instance-id doesn't change on LXD / Focal.

Proposed Commit Message

fix: Integration tests

String output changed in 7703634ec0.
Instance-id doesn't change on LXD / Focal.

Additional Context

https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-noble-lxd_vm/lastCompletedBuild/testReport/
https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-focal-lxd_container/lastCompletedBuild/testReport/tests.integration_tests/test_instance_id/test_instance_id_changes/

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

String output changed in 7703634.
Instance-id doesn't change on LXD / Focal.
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit ea831d6 into canonical:main Aug 2, 2024
23 checks passed
holmanb added a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
String output changed in 7703634.
Instance-id doesn't change on LXD / Focal.
holmanb added a commit that referenced this pull request Aug 6, 2024
String output changed in 7703634.
Instance-id doesn't change on LXD / Focal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants