Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update docs on boothooks #5546

Merged
merged 2 commits into from
Jul 25, 2024
Merged

doc: Update docs on boothooks #5546

merged 2 commits into from
Jul 25, 2024

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Jul 25, 2024

Proposed Commit Message

doc: Update docs on boothooks

Improve explaination on #cloud-boothook for end-users.

Reorder and improve doc/rtd/explanation/format.rst.

SC-1657
Fixes GH-4542

Co-authored-by: Calvin Mwadime <calvin.mwadime@canonical.com>

Additional Context

#5541 (review)

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@aciba90 @CalvoM
doc: Update docs on boothooks
aa8e8e5 
Improve explanation on #cloud-boothook for end-users.

SC-1657
Fixes canonicalGH-4542

Co-authored-by: Calvin Mwadime <calvin.mwadime@canonical.com>
@aciba90 aciba90 requested a review from TheRealFalcon July 25, 2024 08:24
@github-actions github-actions bot added the documentation This Pull Request changes documentation label Jul 25, 2024
@aciba90 aciba90 mentioned this pull request Jul 25, 2024
Closed
2 tasks
s-makin
s-makin approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit, otherwise LGTM :)

@aciba90 @s-makin
Update doc/rtd/explanation/format.rst
1700bee 
Co-authored-by: Sally <sally.makin@canonical.com>
@aciba90
Copy link
Contributor Author

aciba90 commented Jul 25, 2024

Overlaps with: #4739

@TheRealFalcon TheRealFalcon mentioned this pull request Jul 25, 2024
Merged
2 tasks
TheRealFalcon
TheRealFalcon approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit e5e78c2 into canonical:main Jul 25, 2024
24 checks passed
@aciba90 aciba90 deleted the boothook-docs-update branch July 26, 2024 06:41
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
@aciba90 @CalvoM @holmanb
doc: Update docs on boothooks (canonical#5546)
07902d7 
Improve explaination on #cloud-boothook for end-users.

SC-1657
Fixes canonicalGH-4542

Co-authored-by: Calvin Mwadime <calvin.mwadime@canonical.com>
holmanb pushed a commit that referenced this pull request Aug 6, 2024
@aciba90 @CalvoM @holmanb
doc: Update docs on boothooks (#5546)
3a0e2d7 
Improve explaination on #cloud-boothook for end-users.

SC-1657
Fixes GH-4542

Co-authored-by: Calvin Mwadime <calvin.mwadime@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

@s-makin s-makin s-makin approved these changes

Assignees
No one assigned
Labels
documentation This Pull Request changes documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aciba90 @TheRealFalcon @s-makin