Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support charmcraft 3 and multi platform builds #92

Merged
merged 7 commits into from
Mar 3, 2025
Merged

Support charmcraft 3 and multi platform builds #92

merged 7 commits into from
Mar 3, 2025
+18 −60

Conversation

chanchiwai-ray
Copy link
Contributor

@chanchiwai-ray chanchiwai-ray commented Feb 24, 2025 •
edited
Loading

Fixes: #64

@chanchiwai-ray chanchiwai-ray requested a review from a team as a code owner February 24, 2025 07:20
samuelallan72
samuelallan72 requested changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be addressed:

charm-sysconfig/src/tests/functional/conftest.py

Lines 21 to 23 in 9d5635d

# NOTE: When the charm is split into multiple bases,
# this method of getting the charm file needs to be updated.
sources = [("local", os.getenv("CHARM_PATH_JAMMY"))]

@chanchiwai-ray
Copy link
Contributor Author

many dependencies can be removed as we are doing split build now

samuelallan72
samuelallan72 previously approved these changes Feb 27, 2025
View reviewed changes
@chanchiwai-ray chanchiwai-ray mentioned this pull request Feb 28, 2025
Merged
@chanchiwai-ray chanchiwai-ray merged commit 467b6ad into main Mar 3, 2025
6 checks passed
@chanchiwai-ray chanchiwai-ray deleted the charmcraft3 branch March 3, 2025 01:41
chanchiwai-ray added a commit to canonical/solutions-engineering-automation that referenced this pull request Mar 3, 2025
@chanchiwai-ray
Port changes[1] back to automation repo
cf57f15 
[1]: canonical/charm-sysconfig#92
chanchiwai-ray added a commit to canonical/solutions-engineering-automation that referenced this pull request Mar 5, 2025
@chanchiwai-ray
Port changes[1] back to automation repo
de18c17 
[1]: canonical/charm-sysconfig#92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielcocenza gabrielcocenza gabrielcocenza left review comments

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@jneo8 jneo8 jneo8 approved these changes

@Vultaire Vultaire Awaiting requested review from Vultaire Vultaire is a code owner automatically assigned from canonical/soleng-reviewers

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@Deezzir Deezzir Awaiting requested review from Deezzir Deezzir is a code owner automatically assigned from canonical/soleng-reviewers

@sbparke sbparke Awaiting requested review from sbparke sbparke is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support charmcraft 3
4 participants
@chanchiwai-ray @samuelallan72 @jneo8 @gabrielcocenza