Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update centrally managed files #88

Merged
merged 18 commits into from
Feb 20, 2025
Merged

Update centrally managed files #88

merged 18 commits into from
Feb 20, 2025
+99 −2

Conversation

soleng-terraform[bot]
Copy link
Contributor

This is an automated pull request from https://github.com/canonical/solutions-engineering-automation to update centrally managed files.

@soleng-terraform soleng-terraform bot requested a review from a team as a code owner February 5, 2025 15:05
samuelallan72
samuelallan72 previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. func tests are failing, but probably unrelated

Deezzir
Deezzir previously approved these changes Feb 10, 2025
View reviewed changes
@soleng-terraform soleng-terraform bot dismissed stale reviews from Deezzir and samuelallan72 via 46b6757 February 17, 2025 05:37
@samuelallan72 samuelallan72 merged commit 67eba34 into main Feb 20, 2025
5 checks passed
@samuelallan72 samuelallan72 deleted the automation/update-managed-files branch February 20, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@jneo8 jneo8 jneo8 approved these changes

@Deezzir Deezzir Deezzir left review comments

@Vultaire Vultaire Awaiting requested review from Vultaire Vultaire is a code owner automatically assigned from canonical/soleng-reviewers

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@chanchiwai-ray chanchiwai-ray Awaiting requested review from chanchiwai-ray chanchiwai-ray is a code owner automatically assigned from canonical/soleng-reviewers

@sbparke sbparke Awaiting requested review from sbparke sbparke is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelallan72 @jneo8 @Deezzir