Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to release only tested charms #33

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 46 additions & 4 deletions .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,43 @@ jobs:
- name: Run unit tests
run: tox -e unit

func:
build:
needs:
- lint
- unit
name: build charms
runs-on: ${{ matrix.runs-on }}
timeout-minutes: 120
strategy:
fail-fast: false
matrix:
runs-on: [[ubuntu-22.04]]
steps:
- uses: actions/checkout@v4
with:
submodules: true

- uses: canonical/craft-actions/charmcraft/pack@main
id: build
with:
verbosity: verbose
channel: "3.x/stable"

- name: List the names of the built charms
run: echo "${{ steps.build.outputs.charms}}"

- name: Determine system architecture
run: echo "SYSTEM_ARCH=$(uname -m)" >> $GITHUB_ENV

- name: Upload the tested charms
uses: actions/upload-artifact@v4
with:
name: built_charms_${{ env.SYSTEM_ARCH }}
path: ./*.charm

func:
needs:
- build
name: functional tests
runs-on: ${{ matrix.runs-on }}
timeout-minutes: 120
Expand Down Expand Up @@ -115,15 +148,24 @@ jobs:
# set default project to be nested-lxd project
juju model-default project=nested-lxd

- name: Determine system architecture
run: echo "SYSTEM_ARCH=$(uname -m)" >> $GITHUB_ENV

# This is used by zaza in the functional tests for non-amd64 architectures (if applicable)
- name: Set zaza juju model constraints for architecture
run: |
if [ "$(uname -m)" = "aarch64" ]; then
if [ "${{ env.SYSTEM_ARCH }}" = "aarch64" ]; then
echo "TEST_MODEL_CONSTRAINTS=arch=arm64" >> "$GITHUB_ENV"
fi

- name: Build the charm
run: charmcraft -v pack
- name: Download the built charms
uses: actions/download-artifact@v4
with:
name: built_charms_${{ env.SYSTEM_ARCH }}

- name: List the names of the downloaded charms
run: |
ls *.charm

- name: Run tests
run: |
Expand Down
28 changes: 15 additions & 13 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,30 @@ jobs:
uses: ./.github/workflows/check.yaml
secrets: inherit


release:
needs: check
runs-on: ${{ matrix.runs-on }}
strategy:
fail-fast: false
matrix:
runs-on: [[ubuntu-22.04]]
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
with:
submodules: true

- name: Initialize lxd # This should dropped once it's implemented on charming-actions itself. https://github.com/canonical/charming-actions/issues/140
# revision is latest main at time of writing; using because it contains a fix to https://github.com/canonical/setup-lxd/issues/19
uses: canonical/setup-lxd@2aa6f7caf7d1484298a64192f7f63a6684e648a4
- name: Download the tested charms
uses: actions/download-artifact@v4
with:
pattern: charm_*
merge-multiple: true

- name: List the names of the tested charms
run: |
echo "CHARM_NAMES=$(ls *.charm | paste -sd ,)" >> "$GITHUB_ENV"
echo "${{ env.CHARM_NAMES }}"

- name: Pack and upload to charmhub
uses: canonical/charming-actions/upload-charm@2.6.2
- name: Upload the tested charms to charmhub
uses: canonical/charming-actions/upload-charm@2.7.0
with:
charmcraft-channel: "3.x/stable"
credentials: "${{ secrets.CHARMHUB_TOKEN }}"
github-token: "${{ secrets.GITHUB_TOKEN }}"
# Ensure the charm is built in an isolated environment and on the correct base in an lxd container.
destructive-mode: false
built-charm-path: "${{ env.CHARM_NAMES }}"
Loading