Fix listing and running checks with dashes in name #213
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigogansobarbieri
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza,
rgildein and
Deezzir
rodrigogansobarbieri
force-pushed
the
fix_dash_rename
branch
2 times, most recently
from
cb8e886 to
2777d82
Compare
jneo8
previously approved these changes
Dec 10, 2024
rodrigogansobarbieri
force-pushed
the
fix_dash_rename
branch
from
2777d82 to
cad0d99
Compare
|
Latest force-push was to remove a white-space that was added accidentally in the code. |
rodrigogansobarbieri
force-pushed
the
fix_dash_rename
branch
from
cad0d99 to
7421ad1
Compare
|
rebased on top of main |
Pjack
previously approved these changes
Dec 13, 2024
jneo8
previously approved these changes
Dec 16, 2024
|
I think overall is good. But we need you to sign the commit. |
rodrigogansobarbieri
dismissed stale reviews from Pjack and jneo8
via
cb0929a
rodrigogansobarbieri
force-pushed
the
fix_dash_rename
branch
3 times, most recently
from
c7b4f95 to
10c43e5
Compare
The "list-nrpe-checks" action converts underscores to dashes because of key:value juju action result structure, and "run-nrpe-check" converts dashes back to underscores when specifying a check name with dashes. However, if a check name has both dashes and underscores, running the action with the listed check name will never work. This patch using regex search to find the name of the file ignoring dashes and underscores, so it will find the check file in all 3 scenarios. In case there are multiple results it returns an error. Closes: canonical#212
rodrigogansobarbieri
force-pushed
the
fix_dash_rename
branch
from
10c43e5 to
0e8a855
Compare
|
Signed |
jneo8
approved these changes
Dec 18, 2024
gabrielcocenza
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix running checks with both dashes and underscores in name
The "list-nrpe-checks" action converts underscores
to dashes because of key:value juju action result
structure, and "run-nrpe-check" converts dashes back
to underscores when specifying a check name with dashes.
However, if a check name has both dashes and underscores,
running the action with the listed check name will never
work.
This patch using regex search to find the name of the file
ignoring dashes and underscores, so it will find the check file
in all 3 scenarios. In case there are multiple results it returns
an error.
Closes: #212