Add arm64 run-on support #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a classic charm, so no building happens at pack-time. Assuming dependencies build and run correctly on arm64, this is all we need to do from a build perspective to support arm64. build-on arm64 is not strictly required here, but it provides flexibility by supporting building on arm64 hosts too.
Also pin charmcraft to 2.x; latest/stable recently updated to 3.x, but the charmcraft.yaml only supports 2.x.
samuelallan72
force-pushed
the
arm64
branch
2 times, most recently
from
a42e5ce to
b3ca5e6
Compare
This is why the arm64 functional tests are failing. |
``` INFO: /dev/kvm does not exist HINT: sudo modprobe kvm modprobe: FATAL: Module msr not found in directory /lib/modules/6.5.0-1025-azure ```
samuelallan72
requested review from
Pjack,
aieri,
jneo8,
gabrielcocenza,
rgildein and
chanchiwai-ray
samuelallan72
commented
Aug 12, 2024
samuelallan72
commented
Aug 13, 2024
rgildein
reviewed
Aug 13, 2024
rgildein
suggested changes
Aug 13, 2024
jneo8
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a classic charm, so no building happens at pack-time. Assuming dependencies build and run correctly on arm64, this is all we need to do from a build perspective to support arm64.
build-on arm64 is not strictly required here,
but it provides flexibility by supporting building on arm64 hosts too.
The tests are simplified because the arm64 runners don't have kvm support (so we can't deploy the original bundle with virtual-machine type machines).