Build Logs #85
Merged
Build Logs #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
local testing was fine but when i pushed this to our dev env i started getting some weird infinite loop behavior on the logs tab, probably due to react re-rendering the component, so i'm going to test this a bit more |
added 2 commits
February 14, 2025 17:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some functionality to capture build logs from the progress event, store them in the database, and then display them on a tab in the invocations view.
Bazel emits logs a screen at a time, so displaying them on a static page doesn't translate perfectly. For instance if you
catthe actual log file generated from a bazel build, the output is displayed (very quickly) one screen at a time, and then at the end you get a simple message w/just a few lines of detail.Screen.Recording.2025-02-12.at.3.19.36.PM.mov
This naive first pass implementation just captures them, strips any empty/blank lines from the output and renders them with a react module that CSS formats ANSI encoded text. Possible future improvements could allow for users to optionally configure the application to either store build logs or ignore them, streaming build logs in real time, and only pulling the logs from the database on tab load.
Tested with some build logs that run into several MBs worth of data. Seems to hold up okay.