Remove blob download endpoint #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenmj
force-pushed
the
mmj/remove-blob-endpoint
branch
from
7c7167f to
42c2063
Compare
|
Had a conversation with @EdSchouten about the option of using bb-browser, and how that is not considered a public API we can depend on to be stable. After discussing with @trey-ivy we'll go ahead and remove this endpoint for now, and consider adding back similar functionality, but probably a different implementation, if the need arises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need this functionality. It gives us the ability to download blobs from any gRPC CAS backend, but at the expense of unwanted complexity. If we want to provide the ability to download blobs from the UI at all (and we probably do), it seems reasonable to expect the user to also run bb-browser so that we can simply link to that.