Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in documentation files #8794

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

maximevtush
Copy link

No description provided.

@maximevtush maximevtush requested a review from a team as a code owner February 8, 2025 21:37
@adrianbenavides
Copy link
Member

Thanks for submitting this PR! Before we can merge your changes, we need you to do the following:

All commits in this Pull Request are signed and Verified by Github.

and

I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

Let me know if you have any questions.

@maximevtush
Copy link
Author

All commits in this Pull Request are signed and Verified by Github.

I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@adrianbenavides
Copy link
Member

I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

For this to be completed you need to create a separate PR with the CONTRIBUTORS.csv file edited. Please, point me to it if you already did.

One final thing, the CI pipeline doesn't allow merge commits. You need to rebase develop instead like this: git rebase develop and squash all commits into one. Also the commit message must follow some rules, you can write something like: fix(rust): typos in documentation files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants