Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-2863: Optimus with one Starsolo instance #1499

Open
wants to merge 52 commits into
base: develop
Choose a base branch
from
Open

Conversation

aawdeh
Copy link
Contributor

@aawdeh aawdeh commented Feb 5, 2025

Updated the code to eliminate sharding — now, only a single instance of alignment (Starsolo) is running. Removed tasks related to sharding and merging BAM files

  • Removed boolean variable is_slidetags in Optimus and Slide-tags pipelines
  • Removed tasks: FastqProcessing and MergeSortBamFiles
  • Added parameters for STARsoloFastq task, including cpu_platform_star, mem_size_star, cpu_star, disk_star, limitBAMsortRAM_star, and outBAMsortingBinsN_star

Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

Copy link

github-actions bot commented Feb 5, 2025

Remember to squash merge!

1 similar comment
Copy link

github-actions bot commented Feb 5, 2025

Remember to squash merge!

Copy link

github-actions bot commented Feb 5, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Multiome.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
grep: /home/runner/work/warp/warp/pipelines/skylab/optimus/Optimus_One.changelog.md: No such file or directory
Optimus_One.wdl and Optimus_One.changelog.md do not have matching versions
Optimus.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Feb 5, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
fatal: ambiguous argument '/home/runner/work/warp/warp/pipelines/skylab/optimus/Optimus_One.changelog.md': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Optimus.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Feb 5, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Multiome.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
grep: /home/runner/work/warp/warp/pipelines/skylab/optimus/Optimus_One.changelog.md: No such file or directory
Optimus_One.wdl and Optimus_One.changelog.md do not have matching versions
Optimus.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Feb 5, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
fatal: ambiguous argument '/home/runner/work/warp/warp/pipelines/skylab/optimus/Optimus_One.changelog.md': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Optimus.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Feb 6, 2025

Remember to squash merge!

Copy link

github-actions bot commented Feb 6, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Multiome.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
grep: /home/runner/work/warp/warp/pipelines/skylab/optimus/Optimus_One.changelog.md: No such file or directory
Optimus_One.wdl and Optimus_One.changelog.md do not have matching versions
Optimus.wdl has not been changed and needs updating
PairedTag.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Feb 6, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
fatal: ambiguous argument '/home/runner/work/warp/warp/pipelines/skylab/optimus/Optimus_One.changelog.md': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Optimus.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Feb 7, 2025

Remember to squash merge!

Copy link

github-actions bot commented Feb 7, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Feb 7, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Multiome.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not had its version updated
PairedTag.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Feb 7, 2025

Remember to squash merge!

Copy link

github-actions bot commented Feb 7, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Feb 7, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Multiome.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not had its version updated
PairedTag.wdl has not been changed and needs updating
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
SlideSeq.wdl and SlideSeq.changelog.md do not have matching versions
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants