Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcfeval docker image #182

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Update vcfeval docker image #182

merged 2 commits into from
Feb 19, 2025

Conversation

rickymagner
Copy link
Contributor

Just adding some extra documentation for the vcfeval_docker:v1.1 used for an intern project this summer.

@rickymagner rickymagner force-pushed the rm_stratomod_pipeline branch from e0a530f to 7f8a6bd Compare February 19, 2025 15:57
@rickymagner
Copy link
Contributor Author

Just rebased on main and made sure to rebuild + push the dockers to the cloud, since it seems they became out of sync with previous updates. I also took the moment to update the ubuntu base and bump the hts versions. If you have a second to double check the PR again, I'd appreciate it.

P.S. Technically when you updated some of the Dockerfile base ubuntu versions, they might've fallen out of sync with what's in the cloud. Hopefully this doesn't cause any issues, but good to remember.

@rickymagner rickymagner requested a review from kachulis February 19, 2025 15:59
Copy link
Collaborator

@kachulis kachulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. Technically when you updated some of the Dockerfile base ubuntu versions, they might've fallen out of sync with what's in the cloud. Hopefully this doesn't cause any issues, but good to remember.

That is definitely the case. I wonder if we might want to add automated building and pushing of any dockerfile that changes on a push to main. That shouldn't be too difficult, though we'd need to figure out how to automatically bump tags and such things.

more complicated would also be automatically updating references to dockers in wdls when dockerfiles are updated/built/pushed. I think it's doable, but would require a bit of thought on the best way to design (if it's even worth doing)

@rickymagner
Copy link
Contributor Author

I was hoping at some point to think about refactoring our Dockers to use common base images so it'll be easier to maintain the versioning of dependencies across our images, making it easier to bump them all together. We can chat about this at some point if you'd like. I don't think it would take that much time.

@rickymagner rickymagner merged commit a84d1fe into main Feb 19, 2025
10 checks passed
@rickymagner rickymagner deleted the rm_stratomod_pipeline branch February 19, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants