fix: check sp health retry #1411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarryTong65
force-pushed
the
fix-sp-health-retry
branch
3 times, most recently
from
0aa908a to
8c3df84
Compare
clydemeng
reviewed
Jun 3, 2024
| log.CtxErrorw(context.Background(), "failed to check sp healthy", "sp", sp, "http_status_code", resp.StatusCode, "resp_body", resp.Body) | ||
| return false | ||
| if resp.StatusCode == http.StatusOK { | ||
| log.CtxInfow(context.Background(), "succeed to check the sp healthy", "sp", sp, "duration", duration) |
There was a problem hiding this comment.
can we put a metric for the duration so that later we can setup monitor?
clydemeng
reviewed
Jun 3, 2024
| log.CtxInfow(context.Background(), "succeed to check the sp healthy", "sp", sp, "duration", duration) | ||
| return true | ||
| } else { | ||
| log.CtxErrorw(context.Background(), "failed to check sp healthy", "sp", sp, "http_status_code", resp.StatusCode, "resp_body", resp.Body, "duration", duration) |
There was a problem hiding this comment.
If a failure happens when check sp, let's also put a metric
annielz
approved these changes
Jun 3, 2024
BarryTong65
force-pushed
the
fix-sp-health-retry
branch
from
794d10e to
a9ab997
Compare
ruojunm
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: check sp health retry
Rationale
N/A
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts