Piwi code injected in head section since amd method was not working. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would suggest to replace http: and https: from the piwik url, and to approve this PR. |
|
Yes, I second that. |
|
After a week banging my head against the wall, the code in this patch FINALLY made it work. I am so grateful! 😃 Using Plugin version 1.5 (Build: 2017061300) over Moodle 2.9, by the way. |
|
Yeah, @xDaizu that's why it would be great if this pull request was finally accepted to the master branch. |
|
Bas, great to see you have a job at Moodle now. You need to update your profile there https://moodle.org/user/profile.php?id=907814. Also, would you mind integrating this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround (could be one solution?) to #11