Changes for running plugin in Mura 6.2 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into several issues while attempting to run this plugin on Mura 6.2. Changes for this file: Added a trailing slash to the "this.muraAppConfigPath" variable in the pre 7.1 section. Added setting of the request timeout to extend it. This process takes a long time on a server with several pages. I set it to 60 seconds here but it was taking over 1.5 hours on our production server. It will need to be set per installation or configurable perhaps. Added setting of the "session.siteid" because it was being set to "default" when running from the scheduled task. I assume the session does not exist when running from the scheduler. The condition checks for the default setting, and if true then check to see if the "url.site" has been set and uses that. Otherwise stick with "default".
|
Forgot to mention, we should probably add some validation to the "url.site" variable before assigning it to the session. I wasn't sure what limitations (if any) are assigned to the siteid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into several issues while attempting to run this plugin on Mura 6.2. Changes for this file:
Added a trailing slash to the "this.muraAppConfigPath" variable in the pre 7.1 section.
Added setting of the request timeout to extend it. This process takes a long time on a server with several pages. I set it to 60 seconds here but it was taking over 1.5 hours on our production server. It will need to be set per installation or configurable perhaps.
Added setting of the "session.siteid" because it was being set to "default" when running from the scheduled task. I assume the session does not exist when running from the scheduler. The condition checks for the default setting, and if true then check to see if the "url.site" has been set and uses that. Otherwise stick with "default".