-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix concurrency problems #10
Open
bioinformatist
wants to merge
20
commits into
main
Choose a base branch
from
fix/concurrency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time` field of `Metadata`; pub use somethings
* test: add tests for Task and Inference - add test_task_running_in_parallel() - rewrite the test of Inference - update deadpool - change vec<&str> into &[&str]
@lazyky There are still some issues with the unit test for |
…[String]` for easier use with clap
* refactor: delete unnecessary code - Use ? for `anyhow::Result` - delete unnecessary `async` * refactor: refactor the use of asynchronous
* feat: Optimize the timing of task run() - Change model_update_time tag in Stable training_data to train_start_time - Add update_train_start_time() to update by timestamp of latest available model - Delete model_update_time in Metadata
@lazyky It is recommended to merge structure |
- merge TaskConfig for other kind of database may need different configurations - Add current_ts for distributed systems
temply remove dead mission checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lazyky 义父,please assist me in completing this PR. The tasks that need to be done are as follows:
derive-builder
withtyped-builder
.Inference
trait to cover the scenario of two threads simultaneously operating on the same batch (you can refer to theRegister
trait for guidance).tempfile::NamedTempFile
for temporary files.working_status
, which is a property ofTaskConfig
, with&[&str]
, which is the same as the signature ofInference::inference
.test_task_running_in_parallel()
(just leave the comments there, I'll add examples with Burn later).Metadata
now usesOption<i64>
instead of a regulari64
type for themodel_update_time
field. Please make sure to update this in theInference
trait accordingly.data_path
field should be removed everywhere.Vec<T>
, rendering the relative fields obsolete in both theRegister
andInference
trait.