Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generic hook callbacks instead of action callbacks #39

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

davidlougheed
Copy link
Member

BREAKING CHANGE: signature changes for various hooks

rationale: actions shouldn't be tied to the state type, since the state type in auth_js =/= the state type in a library using it...

BREAKING CHANGE: signature changes for various hooks

rationale: actions shouldn't be tied to the state type, since the state type
in auth_js =/= the state type in a library using it...
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidlougheed davidlougheed merged commit 96f9ed0 into main Nov 8, 2024
2 checks passed
@davidlougheed davidlougheed deleted the refact/typing-callbacks branch November 8, 2024 15:43
Copy link

github-actions bot commented Nov 8, 2024

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants