Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker build support #27

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

bekriebel
Copy link
Contributor

These changes add a Dockerfile and config example for running with Docker. The readme is updated with example commands. I also added a github workflow that will build the docker image and deploy it to the GitHub container registry for the project.

The Dockerfile builds the frontend and backend as two separate stages
and combines them in a slim runtime image. The example env file works
as a local configuration for testing or development.
Will build the docker image and push it to github's container registry.
Triggered manually with a workflow dispatch.
If the `PINGING_PUBLIC_WEBRTC_ADDR` is set with an unspecified IP value
(`0.0.0.0`), attempt to automatically detect the public IP address of
the server.
@bekriebel
Copy link
Contributor Author

I added a couple of other changes to this PR that I wanted for my specific use case. One lets the app automatically determine the public IP, and the other adds the IP to the front-end display (to help distinguish which server in a cluster is in use).

If you want the docker changes but not these other changes, let me know, and I can break them out and continue to use my own fork.

@benhansen-io benhansen-io merged commit f5bc241 into benhansen-io:main Nov 22, 2024
6 checks passed
@benhansen-io
Copy link
Owner

Thanks for the improvements. I don't have much experience with docker but what you have looks good to me. The public-ip stuff looks good too. I think its fine for pinging.net to display the IP address (its already small and at the bottom).

I am curious what your planned usage is if you are able to share. No worries if not. Thanks again.

@bekriebel
Copy link
Contributor Author

I am curious what your planned usage is if you are able to share. No worries if not. Thanks again.

My company is building a new A/V streaming & broadcasting solution. I wanted an extra way for our alpha testers to check their connectivity to our servers. I'm deploying this alongside our services on the same infrastructure, so if users hit a specific address they can see the pinging report and let us know if they are seeing any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants