Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BADGERS-575: [BREAKING] Audio Described Unification #365

Open
wants to merge 213 commits into
base: master
Choose a base branch
from

Conversation

ShiningTrapez
Copy link
Contributor

@ShiningTrapez ShiningTrapez commented Jan 29, 2025

📺 What
Allows for Replacing Sources in a set up BSP session, adds infrastructure around this to allow for using this mechanism for a generic Audio Described solution. This method requires a seperate set of sources to be passed in in a new audioDescribed block, rather than using a combined manifest as the MSE Implementation. Both mechanisms can be controlled via the same API Functions, now called audioDescribed instead of broadcastMixAD, the mechanism used will be selected based on the provided sources, with the generic approach taking precedence if both an audioDecribed block and Manifest containing Audio Described tracks is present.

🛠 How
Overwrite the variable in flight and then reload manifest

eirikbjornr and others added 30 commits November 6, 2024 15:20
Co-authored-by: matt-stephenson <matt-stephenson@users.noreply.github.com>
Base automatically changed from badgers-245-manifest-driven to master February 20, 2025 12:31
@ShiningTrapez ShiningTrapez marked this pull request as ready for review February 26, 2025 14:59
@ShiningTrapez ShiningTrapez requested a review from a team as a code owner February 26, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver major This PR is a semver major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants