-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BADGERS-575: [BREAKING] Audio Described Unification #365
Open
ShiningTrapez
wants to merge
213
commits into
master
Choose a base branch
from
BADGERS-575
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+993
−424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p associated tests
Co-authored-by: matt-stephenson <matt-stephenson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 What
Allows for Replacing Sources in a set up BSP session, adds infrastructure around this to allow for using this mechanism for a generic Audio Described solution. This method requires a seperate set of sources to be passed in in a new
audioDescribed
block, rather than using a combined manifest as the MSE Implementation. Both mechanisms can be controlled via the same API Functions, now calledaudioDescribed
instead ofbroadcastMixAD
, the mechanism used will be selected based on the provided sources, with the generic approach taking precedence if both anaudioDecribed
block and Manifest containing Audio Described tracks is present.🛠 How
Overwrite the variable in flight and then reload manifest