BCR Presubmit: check metadata.json file changes #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @fmeum |
fweikert
reviewed
Jan 23, 2024
fweikert
approved these changes
Jan 23, 2024
|
@meteorcloudy Have you checked whether CI uses the workflow definitions from the main branch or those from the PR branch? The latter would be problematic, but it's how e.g. GitHub Actions would work by default. |
|
Do you mean this specific check? This is implemented in the CI repo not the BCR repo, so it's always using the HEAD version of the CI repo. The bcr_validation.py is used from the PR branch, but we did check beforehand that nothing outside of modules/ are changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If information like, maintainers, homepage, repository is changed in the module's metadata.json file, the presubmit should wait for a BCR maintainer review.
Context bazelbuild/bazel-central-registry#1363 (comment)