Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template out the data folder for TGI / VLLM #622

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

varunshenoy
Copy link
Contributor

Currently, users must have a data_dir if they're using the hf_cache key. In reality, this should not be the case. The data_dir is only necessary if they have account credentials (e.g. gcs) for their bucket. For caching Hugging Face weights, there may be no data_dir.

@varunshenoy varunshenoy requested a review from bolasim August 28, 2023 16:43
@varunshenoy varunshenoy merged commit f0c421e into main Aug 28, 2023
@varunshenoy varunshenoy deleted the varun/template-data-folder branch August 28, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants