fix: Unable to deploy with cert-manager when certain options are set #661
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ook set to Fail and Secret mutation is enabled Signed-off-by: Rafael da Fonseca <rafael.fonseca@wildlifestudios.com>
rsafonseca
changed the title
|
Hi @rsafonseca, Can you open a PR in Secrets-webhook too? |
csatib02
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a chicken and egg problem when mutatingwebhook set to Fail and Secret mutation is enabled, in which case vault-secrets-webhook is not yet started (waiting for certificate) and cert-manager cannot issue the Certificate because the secret is blocked by the webhook created on install
Overview
Fixes #(issue)
Notes for reviewer