Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add everything Azure guide #202

Merged
merged 1 commit into from
Feb 15, 2024
Merged

docs: add everything Azure guide #202

merged 1 commit into from
Feb 15, 2024

Conversation

akijakya
Copy link
Member

Overview

Fixes bank-vaults/vault-operator#132

Notes for reviewer

@akijakya akijakya self-assigned this Jan 18, 2024
@akijakya akijakya requested a review from a team as a code owner January 18, 2024 13:43
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-499 lines label Jan 18, 2024
@akijakya akijakya force-pushed the everything-azure-guide branch from c57d1ca to e6e246f Compare January 23, 2024 15:15
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@lgecse lgecse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akijakya
Copy link
Member Author

I used we instead of you in some places but that is also fixed now, thanks for noticing @lgecse.

Another thing: maybe we could put this guide where all the community-written blog post will go on the docs page, what do you think @ramizpolic, @fekete-robert, @lgecse?

@ramizpolic
Copy link
Member

I used we instead of you in some places but that is also fixed now, thanks for noticing @lgecse.

Another thing: maybe we could put this guide where all the community-written blog post will go on the docs page, what do you think @ramizpolic, @fekete-robert, @lgecse?

it can be linked there, but not created. I would add this to https://bank-vaults.dev/docs/tips-and-tricks/ under Guide - Run Bank-Vaults stack on Azure

@akijakya
Copy link
Member Author

akijakya commented Feb 2, 2024

@ramizpolic I like your title suggestion so applied it, WDYT can we merge this?

@ramizpolic
Copy link
Member

Added some notes @akijakya, feel free to merge once addressed. Thanks a lot, looks great!

@ramizpolic ramizpolic self-requested a review February 9, 2024 19:32
@akijakya akijakya force-pushed the everything-azure-guide branch from 0bb7ac1 to 4c77d35 Compare February 13, 2024 14:26
@akijakya
Copy link
Member Author

Added some notes @akijakya, feel free to merge once addressed. Thanks a lot, looks great!

Thanks for the meticulous review! 🙂

Signed-off-by: András Jáky <ajaky@cisco.com>
@akijakya akijakya force-pushed the everything-azure-guide branch from 4c77d35 to 3fd9f03 Compare February 13, 2024 14:29
@ramizpolic
Copy link
Member

something wrong with the pipeline 😢

@ramizpolic
Copy link
Member

works, not sure why, same for why it was failing 🤣

@akijakya akijakya merged commit fb5020c into main Feb 15, 2024
@akijakya akijakya deleted the everything-azure-guide branch February 15, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth area/provider/azure area/storage kind/documentation Categorizes issue or PR as related to documentation. size/M Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs on how to use Azure as storage
4 participants