Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Cleanup from staticcheck #337

Merged
merged 4 commits into from
Feb 8, 2024
Merged

[Chore] Cleanup from staticcheck #337

merged 4 commits into from
Feb 8, 2024

Conversation

RogerKSI
Copy link
Contributor

@RogerKSI RogerKSI commented Feb 3, 2024

Implementation details

  • replace deprecated function/package
  • formatting code
  • fix some typos in the document
  • fix CI file

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI requested review from satawatnack, taobun and colmazia and removed request for satawatnack February 3, 2024 11:54
@RogerKSI RogerKSI requested a review from taobun February 5, 2024 08:44
@colmazia colmazia merged commit 6f0f015 into master Feb 8, 2024
2 checks passed
@colmazia colmazia deleted the cleanup branch February 8, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants