Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement revised annotation changes and compiler validations #60

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

hasathcharu
Copy link
Contributor

Purpose

Implemented the revised annotations and updated compiler validations and test cases for the below task.
Fixes: ballerina-platform/ballerina-library#6180

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 72.63158% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 84.73%. Comparing base (ecf3ece) to head (7147315).

Files Patch % Lines
.../persist/sql/compiler/pluginutils/PluginUtils.java 42.50% 8 Missing and 15 partials ⚠️
...l/compiler/PersistSqlModelDefinitionValidator.java 92.85% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #60      +/-   ##
============================================
- Coverage     85.67%   84.73%   -0.94%     
- Complexity      255      264       +9     
============================================
  Files            23       23              
  Lines          1619     1677      +58     
  Branches        445      466      +21     
============================================
+ Hits           1387     1421      +34     
- Misses          148      156       +8     
- Partials         84      100      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daneshk daneshk merged commit 4b8c6cc into ballerina-platform:main Mar 14, 2024
6 of 7 checks passed
@hasathcharu hasathcharu deleted the annotation-change branch May 8, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make changes to advanced SQL annotation definitions
2 participants