Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced annotation support for SQL databases for name, type, indexes and generated fields #59

Merged
merged 25 commits into from
Mar 12, 2024

Conversation

hasathcharu
Copy link
Contributor

@hasathcharu hasathcharu commented Feb 27, 2024

Purpose

To add advanced annotation support for SQL databases for name mapping, type mapping, relation mapping, indexes and auto generated columns to support database introspection. Compiler validations for the new annotations are also added in this PR.

Fixes:

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 89.36709% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 85.67%. Comparing base (8907ed0) to head (71d61bc).

Files Patch % Lines
.../persist/sql/compiler/pluginutils/PluginUtils.java 47.82% 11 Missing and 13 partials ⚠️
...l/compiler/PersistSqlModelDefinitionValidator.java 94.73% 2 Missing and 14 partials ⚠️
ballerina/sql_client.bal 81.81% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #59      +/-   ##
============================================
+ Coverage     83.35%   85.67%   +2.31%     
- Complexity      169      255      +86     
============================================
  Files            22       23       +1     
  Lines          1256     1619     +363     
  Branches        359      445      +86     
============================================
+ Hits           1047     1387     +340     
+ Misses          152      148       -4     
- Partials         57       84      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hasathcharu hasathcharu requested a review from Bhashinee March 11, 2024 09:08
@daneshk daneshk merged commit ecf3ece into ballerina-platform:main Mar 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants