-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced annotation support for SQL databases for name, type, indexes and generated fields #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
============================================
+ Coverage 83.35% 85.67% +2.31%
- Complexity 169 255 +86
============================================
Files 22 23 +1
Lines 1256 1619 +363
Branches 359 445 +86
============================================
+ Hits 1047 1387 +340
+ Misses 152 148 -4
- Partials 57 84 +27 ☔ View full report in Codecov by Sentry. |
Bhashinee
reviewed
Mar 11, 2024
Bhashinee
reviewed
Mar 11, 2024
Bhashinee
reviewed
Mar 11, 2024
Bhashinee
reviewed
Mar 11, 2024
Bhashinee
reviewed
Mar 11, 2024
...r-plugin-test/src/test/java/io/ballerina/stdlib/persist/sql/compiler/CompilerPluginTest.java
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 11, 2024
...r-plugin-test/src/test/java/io/ballerina/stdlib/persist/sql/compiler/CompilerPluginTest.java
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 11, 2024
...r-plugin-test/src/test/java/io/ballerina/stdlib/persist/sql/compiler/CompilerPluginTest.java
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 11, 2024
compiler-plugin-test/src/test/resources/project_1/persist/char.bal
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 11, 2024
compiler-plugin-test/src/test/resources/project_1/persist/char.bal
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 11, 2024
compiler-plugin-test/src/test/resources/project_1/persist/char.bal
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 11, 2024
compiler-plugin-test/src/test/resources/project_1/persist/decimal.bal
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 11, 2024
compiler-plugin-test/src/test/resources/project_1/persist/entity_name_mapping.bal
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 11, 2024
daneshk
reviewed
Mar 11, 2024
compiler-plugin-test/src/test/resources/modelvalidator/Ballerina.toml
Outdated
Show resolved
Hide resolved
daneshk
reviewed
Mar 11, 2024
daneshk
reviewed
Mar 12, 2024
compiler-plugin-test/src/test/resources/modelvalidator/persist/compilationerror.bal
Outdated
Show resolved
Hide resolved
daneshk
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To add advanced annotation support for SQL databases for name mapping, type mapping, relation mapping, indexes and auto generated columns to support database introspection. Compiler validations for the new annotations are also added in this PR.
Fixes:
Checklist